[ 
http://jira.codehaus.org/browse/MRM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_103763
 ] 

Maria Odea Ching commented on MRM-329:
--------------------------------------

Thanks for the patch Teody.. the reports definitely looks better now :)

I agree with Brett's comments, especially the constraints/fields being grouped 
together in one form. It'll be easier for the user to use. 
Below are some additional comments:
- Can the version link in the reports be removed? I think it would always 
display the 'Unable to find...' error message whenever you click it since the 
project model is never added to the database once it is found to be invalid
- Could you provide some unit tests for these?
- And lastly, what about the reports not being accessible to only those users 
with admin roles? Should that be included here? Or is that a separate issue?

Btw, I didn't see the tanuki WrapperSimpleApp started when I executed the 
reports :)

> The Reports link gives an HTTP 500
> ----------------------------------
>
>                 Key: MRM-329
>                 URL: http://jira.codehaus.org/browse/MRM-329
>             Project: Archiva
>          Issue Type: Bug
>          Components: reporting
>    Affects Versions: 1.0-alpha-1
>            Reporter: Napoleon Esmundo C. Ramirez
>            Assignee: Joakim Erdfelt
>            Priority: Blocker
>             Fix For: 1.0-beta-1
>
>         Attachments: MRM-329-archiva-database-20070725.patch, 
> MRM-329-archiva-database-20070801.patch, 
> MRM-329-archiva-model-20070727.patch, MRM-329-archiva-model-20070801.patch, 
> MRM-329-archiva-webapp-20070725.patch, MRM-329-archiva-webapp-20070801.patch
>
>
> Clicking the Reports link in the side navigation menu displays the following 
> (edited/snipped stacktrace): 
> HTTP ERROR: 500
> RequestURI=/admin/reports.action
> Caused by: javax.el.PropertyNotFoundException: The class 
> 'org.apache.maven.archiva.reporting.artifact.OldArtifactReport' does not have 
> the property 'groupId'.
> at javax.el.BeanELResolver.getBeanProperty(BeanELResolver.java:574)
> at javax.el.BeanELResolver.getValue(BeanELResolver.java:280)
> at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:143)
> at com.sun.el.parser.AstValue.getValue(AstValue.java:118)
> at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:192)
> at 
> org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:974)
> at 
> org.apache.jsp.WEB_002dINF.jsp.reports.reports_jsp._jspx_meth_c_forEach_0(org.apache.jsp.WEB_002dINF.jsp.reports.reports_jsp:143)
> at 
> org.apache.jsp.WEB_002dINF.jsp.reports.reports_jsp._jspService(org.apache.jsp.WEB_002dINF.jsp.reports.reports_jsp:85)
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:111)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
> at 
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:373)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to