[ 
https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826841#comment-17826841
 ] 

ASF GitHub Bot commented on MCOMPILER-582:
------------------------------------------

kwin commented on code in PR #228:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523805676


##########
src/site/apt/examples/set-compiler-release.apt.vm:
##########
@@ -106,3 +111,34 @@ Setting the <<<--release>>> of the Java Compiler
   [...]
 </project>
 +-----
+
+* Usage on JDK 8 - automatic detection

Review Comment:
   I would remove this line, as this is not really restricted to JDK8





> Release option without profile for JDK 8
> ----------------------------------------
>
>                 Key: MCOMPILER-582
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-582
>             Project: Maven Compiler Plugin
>          Issue Type: New Feature
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.13.0
>
>
> Since plexus-compiler 2.15.0 `--release` options is automatically disregarded 
> for javac version < 9 
> (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no 
> longer necessary to guard that parameter with a profile.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to