[ 
https://issues.apache.org/jira/browse/MCOMPILER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826840#comment-17826840
 ] 

ASF GitHub Bot commented on MCOMPILER-582:
------------------------------------------

kwin commented on code in PR #228:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/228#discussion_r1523805011


##########
src/site/apt/examples/set-compiler-release.apt.vm:
##########
@@ -85,7 +85,12 @@ Setting the <<<--release>>> of the Java Compiler
 
   The <<<--release>>> option is not supported using JDK 8. To enable a project 
that targets Java 8
   to be built using JDK 8 and also JDK 9 or later requires the conditional 
usage of the
-  <<<--release>>> option. This may be done through the use of a profile:
+  <<<--release>>> option.
+
+  Conditional profile is required for the Compiler Plugin version below 
<<<3.13.0>>>

Review Comment:
   ```suggestion
     Conditional parametrization is required for the Compiler Plugin version 
below <<<3.13.0>>>
   ```





> Release option without profile for JDK 8
> ----------------------------------------
>
>                 Key: MCOMPILER-582
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-582
>             Project: Maven Compiler Plugin
>          Issue Type: New Feature
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>             Fix For: 3.13.0
>
>
> Since plexus-compiler 2.15.0 `--release` options is automatically disregarded 
> for javac version < 9 
> (https://github.com/codehaus-plexus/plexus-compiler/issues/140). It is no 
> longer necessary to guard that parameter with a profile.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to