[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811536#comment-17811536
]
Herve Boutemy edited comment on DOXIASITETOOLS-328 at 1/27/24 3:40 PM:
-----------------------------------------------------------------------
thinking out loud; re-reading how the edit link is rendered in the default skin
https://github.com/apache/maven-doxia-sitetools/commit/80ba2e77db46b2a523af2df44a937e7fd25f3d42
DocumentRenderingContext makes the link between source markup and rendered
html:
https://github.com/apache/maven-doxia-sitetools/blob/master/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DocumentRenderingContext.java#L286
in your case, source markup is not in src/site but in target/site-src
(configured in m-site-p siteDirectory parameter), because this is the result or
resource processing
adding an extra "editSiteDirectory" parameter in m-site-p that would be by
default the same as "siteDirectory" could probably do the job
but the semantics of everything is hard to track from m-site-p to
doxia-siterenderer to skin...
was (Author: hboutemy):
thinking out loud; re-reading how the edit link is rendered in the default skin
https://github.com/apache/maven-doxia-sitetools/commit/80ba2e77db46b2a523af2df44a937e7fd25f3d42
DocumentRenderingContext makes the link between source markup and rendered
html:
https://github.com/apache/maven-doxia-sitetools/blob/master/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DocumentRenderingContext.java#L286
in your case, source markup is not in src/site but in target/site-src
(configured in m-site-p siteDirectory parameter), because this is the result or
resource processing
adding an extra "editSiteDirectory" parameter in m-site-p that would be by
default the same as "siteDirectory" could probably do the job
> Allow to overwrite the edit source link with an alternative folder
> ------------------------------------------------------------------
>
> Key: DOXIASITETOOLS-328
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-328
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Reporter: Konrad Windszus
> Priority: Major
>
> Sometimes regular Maven filtering is used to preprocess the doxia source
> files (for placeholder replacement only) when Velocity is just too much
> overhead/requires workarounds e.g. for level 2 headlines with markdown
> (https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#Filtering),
> compare with DOXIA-677.
> In that case the generated edit button links to the wrong (temporary)
> location which was used as the input directory for the site (but is actually
> below {{target/....}}) and therefore not available in the SCM. For example
> look at the edit button in
> https://jackrabbit.apache.org/filevault-package-maven-plugin-archives/1.3.4/dev.html.
> There should be the possibility to give an alternative source directory for
> generating the edit link (instead of the one given through
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#siteDirectory)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
