[
https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807060#comment-17807060
]
ASF GitHub Bot commented on MARCHETYPES-82:
-------------------------------------------
hboutemy commented on code in PR #28:
URL: https://github.com/apache/maven-archetypes/pull/28#discussion_r1452968733
##########
maven-archetype-quickstart/src/test/resources/projects/it-java-7-junit-4.12/reference/pom.xml:
##########
@@ -15,6 +15,7 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
+ <!--maven.compiler.target>11</maven.compiler.target-->
Review Comment:
no, this one is a unit test with value defined in command line: user can
decide to generate with forced 1.7 value, that's a good test to keep
> generate maven.compiler.release property as comment
> ---------------------------------------------------
>
> Key: MARCHETYPES-82
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-82
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Affects Versions: 1.4
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 1.5
>
>
> if JDK 11+ is used to compile, it's better to define maven.compiler.release
> instead of maven.compiler.source/target
> we currently generate for Java 8, so we don't really know if the compiler
> used support release parameter
> adding a comment is a good first step to help discovery, before benefiting
> from MARCHETYPES-70 when generating against newer JDK
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
