[
https://issues.apache.org/jira/browse/MARCHETYPES-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806684#comment-17806684
]
ASF GitHub Bot commented on MARCHETYPES-82:
-------------------------------------------
judovana commented on PR #28:
URL: https://github.com/apache/maven-archetypes/pull/28#issuecomment-1891540458
I still think the
```
<maven.compiler.source>${javaCompilerVersionLocal}</maven.compiler.source>
<maven.compiler.target>${javaCompilerVersionLocal}</maven.compiler.target>
+ <!--maven.compiler.target>11</maven.compiler.target-->
```
is misplaced, and should be at
https://github.com/apache/maven-archetypes/blob/master/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L49
Generally I think this commit is not helpful, as it will just confuse any
future grep/sed and generally any maven user/java developer should be able to
bump 8 to 11, or generally to anything they need.
I had missed reasoning why you actually proposed this changeset.
Thanx for merging #27 . As for this, I'm -1, but I do not have any
permissions of any weight :) Good luck!
> generate maven.compiler.release property as comment
> ---------------------------------------------------
>
> Key: MARCHETYPES-82
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-82
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Affects Versions: 1.4
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 1.5
>
>
> if JDK 11+ is used to compile, it's better to define maven.compiler.release
> instead of maven.compiler.source/target
> we currently generate for Java 8, so we don't really know if the compiler
> used support release parameter
> adding a comment is a good first step to help discovery, before benefiting
> from MARCHETYPES-70 when generating against newer JDK
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
