[ 
https://issues.apache.org/jira/browse/DOXIA-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806457#comment-17806457
 ] 

Abel Salgado Romero edited comment on DOXIA-725 at 1/14/24 11:40 AM:
---------------------------------------------------------------------

Thanks, [~kwin] but I am sorry to say that doesn't help me.

I create a SiteRendererSink for tests only, that's where I found the 
incompatibility; because my tests cannot run now. My module contains a parser 
module 
[https://github.com/abelsromero/asciidoctor-maven-plugin/blob/issue-578-experimental-maven-site-4.x.x/asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/ast/AsciidoctorAstDoxiaParserModule.java,|https://github.com/abelsromero/asciidoctor-maven-plugin/blob/issue-578-experimental-maven-site-4.x.x/asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/ast/AsciidoctorAstDoxiaParserModule.java,m]
 that what it's not being detected past `asciidoctor-maven-site 4.0.0-M4` 
because I see no logs and the associated parser 
[https://github.com/abelsromero/asciidoctor-maven-plugin/blob/issue-578-experimental-maven-site-4.x.x/asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/ast/AsciidoctorAstDoxiaParser.java]
 does not run at all.

 

I suspect Modules need to be defined in a different way now?


was (Author: abel s.romero):
Thanks, [~kwin] but I am sorry to say that doesn't help me.

I create a SiteRendererSink for tests only, that's where I found the 
incompatibility; because my tests cannot run now. My module contains a parser 
module 
[https://github.com/abelsromero/asciidoctor-maven-plugin/blob/issue-578-experimental-maven-site-4.x.x/asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/ast/AsciidoctorAstDoxiaParserModule.java,|https://github.com/abelsromero/asciidoctor-maven-plugin/blob/issue-578-experimental-maven-site-4.x.x/asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/ast/AsciidoctorAstDoxiaParserModule.java,m]
 that what it's not being detected past `asciidoctor-maven-site 4.0.0-M4` 
because I see no logs and the associated parser 
[https://github.com/abelsromero/asciidoctor-maven-plugin/blob/issue-578-experimental-maven-site-4.x.x/asciidoctor-parser-doxia-module/src/main/java/org/asciidoctor/maven/site/ast/AsciidoctorAstDoxiaParser.java]
 does not run at all.

> Latest Doxia Core is not compatible with doxia-sitetools
> --------------------------------------------------------
>
>                 Key: DOXIA-725
>                 URL: https://issues.apache.org/jira/browse/DOXIA-725
>             Project: Maven Doxia
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-M9
>            Reporter: Abel Salgado Romero
>            Priority: Major
>             Fix For: waiting-for-feedback
>
>
> Testing Milestones I found `doxia-core` 4.0.0-M9 is not compatible with 
> `doxia-sitetools`.
> This commit 
> [https://github.com/apache/maven-doxia/commit/0dfe227b6603151b8b460d2b7cacc8953a512f4f]
>  final methods where added to `AbstractSink` class, those are still present 
> in sub-classes like `SiteRendererSink` which now fail instantiation with:
> ```
> java.lang.IncompatibleClassChangeError: class 
> org.apache.maven.doxia.siterenderer.sink.SiteRendererSink overrides final 
> method org.apache.maven.doxia.sink.impl.AbstractSink.head(
> ```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to