cstamas commented on code in PR #1367:
URL: https://github.com/apache/maven/pull/1367#discussion_r1447349763


##########
maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLookup.java:
##########
@@ -24,6 +24,8 @@
 

Review Comment:
   Perso, I'd even move Lookup service to "internal service" (like CoreRealm 
is), not exposing it to plugins. It serves a very good purpose in Core (to hide 
Plexus), while plugins can achieve all these with plain JSR330 (or Maven 
specific JSR330-like annos if they become to existence once).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to