rmannibucau commented on code in PR #1367: URL: https://github.com/apache/maven/pull/1367#discussion_r1447320254
########## maven-core/src/main/java/org/apache/maven/internal/impl/DefaultLookup.java: ########## @@ -24,6 +24,8 @@ Review Comment: thinking a bit out loud there but I'm starting to wonder if we should expose guice Injector instead of this container wrapper which basically propagate the status-quo in terms of number of containers in the API and have a single lookup(Type) method. Probably something to think about before releasing this since ultimately this will need to move from internal to public cause it is a common need to be able to lookup public components programmatically (scripting case being the extreme example). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
