kwin commented on code in PR #201:
URL: https://github.com/apache/maven-release/pull/201#discussion_r1439031745
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##########
@@ -96,7 +96,7 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
* Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
* The first group selects the property name the expression refers to.
*/
- private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+ private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+?)\\}");
Review Comment:
No it isn’t:
https://docs.oracle.com/javase/tutorial/essential/regex/quant.html. The former
is greedy while the latter is reluctant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
