elharo commented on code in PR #102:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/102#discussion_r1438922443
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/DefaultMethodVisitor.java:
##########
@@ -157,4 +160,14 @@ private void addTypeSignature(final String signature) {
new SignatureReader(signature).acceptType(signatureVisitor);
}
}
+
+ @Override
+ public void visitInvokeDynamicInsn(
Review Comment:
Insn --> Instruction
I had to think about this one to figure it out.
In general, avoid abbreviations
##########
src/test/java/org/apache/maven/shared/dependency/analyzer/asm/ASMDependencyAnalyzerTest.java:
##########
@@ -40,4 +43,12 @@ void test() throws Exception {
assertThat(result).isNotEmpty();
}
+
+ @Test
+ void verify_implicit_class_reference_included_in_used_classes() throws
IOException {
Review Comment:
naming convention seems wonky here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
