[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801249#comment-17801249
]
ASF GitHub Bot commented on DOXIA-714:
--------------------------------------
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438391211
##########
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##########
@@ -45,12 +48,9 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
// Instance fields
// ----------------------------------------------------------------------
- /** A buffer that holds the current text when headerFlag or bufferFlag
set to <code>true</code>. */
+ /** A buffer that holds the current text when headerFlag or bufferFlag
set to <code>true</code>. This value of this buffer is already escaped. */
Review Comment:
Fixed.
##########
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##########
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
- /** tableCellFlag. */
+ /** tableCellFlag, set to true inside table (header) cells */
Review Comment:
Fixed
> MarkdownSink: Fix table justification and figures
> -------------------------------------------------
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)