[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801234#comment-17801234
]
ASF GitHub Bot commented on DOXIA-714:
--------------------------------------
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438356143
##########
doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java:
##########
@@ -208,6 +208,19 @@ protected String getTableBlock(String cell, String
caption) {
+ "</td></tr></table>";
}
+ @Override
+ protected String getTableWithHeaderBlock(String... rowPrefixes) {
+ return "<table border=\"0\">\n<tr>\n<th>" + rowPrefixes[0] +
"0</th>\n<th>" + rowPrefixes[0] + "1</th>\n<th>"
Review Comment:
This is just what is emitted currently for the newly added test in the
`AbstractParserTest`. Fixing the output should be done separately if you
consider it wrong.
> MarkdownSink: Fix table justification and figures
> -------------------------------------------------
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
