judovana commented on code in PR #18: URL: https://github.com/apache/maven-archetypes/pull/18#discussion_r1432919700
########## maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml: ########## @@ -1,11 +1,11 @@ <?xml version="1.0" encoding="UTF-8"?> -#macro( compilerProperties $javaCompilerVersion ) +#macro( compilerProperties $jcv ) Review Comment: There was the name clash between global and local variable. wanted to make clear, that it is obvious on first glance, what is local to macro, and what is global one. See https://github.com/apache/maven-archetypes/blob/master/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L2 compare with full: https://github.com/judovana/maven-archetypes/blob/defaultJdk8/maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml#L48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
