schedin commented on code in PR #18:
URL: 
https://github.com/apache/maven-jarsigner-plugin/pull/18#discussion_r1424124469


##########
src/main/java/org/apache/maven/plugins/jarsigner/AbstractJarsignerMojo.java:
##########
@@ -279,65 +280,70 @@ public final void execute() throws MojoExecutionException 
{
             jarSigner.setToolchain(toolchain);
         }
 
-        int processed = 0;
+        List<File> archives = findJarfiles();
+        processArchives(archives);
+        getLog().info(getMessage("processed", archives.size()));
+    }
 
+    /**
+     * Finds all jar files, by looking at the Maven project and user 
configuration.
+     *
+     * @return a List of File objects
+     * @throws MojoExecutionException if it was not possible to build a list 
of jar files.
+     */
+    private List<File> findJarfiles() throws MojoExecutionException {

Review Comment:
   Once again the diff on GitHub displays like I have changed the entire 
function. View the diff from an IDE to easier see what rows I have only 
re-indented.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to