mfussenegger commented on code in PR #672:
URL: https://github.com/apache/maven-surefire/pull/672#discussion_r1367388265


##########
maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm:
##########
@@ -36,6 +36,9 @@ Using Maven Toolchains with ${thisPlugin}.
     guide, ${thisPlugin} will launch the test jvm using the main toolchain
     configured in Maven.
 
+    Note that options like <<<forkCount>>> prevent the toolchains from being 
used.
+    See {{{https://issues.apache.org/jira/browse/SUREFIRE-720}}SUREFIRE-720} 
for more information.
+

Review Comment:
   Isn't
   
   > Note that options like <<<forkCount>>> prevent the toolchains from being 
used.
   
   describing the impact?
   
   I'm not familiar with the exact details why it is not working. If you expect 
that then someone else has to make the changes.
   
   I'd think this is at least an improvement over the status quo, because 
currently it says that surefire picks up toolchains by default, while it 
doesn't if forkCount is set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to