GitPopcorn commented on issue #883: URL: https://github.com/apache/maven-mvnd/issues/883#issuecomment-1722255904
> Hi @GitPopcorn, I wonder how safe it is to pass `-Dfile.encoding` to an already running daemon. Java caches the value of "file.encoding" in some of it's core classes. Hence once the daemon java process is up, passing a new value via `-Dfile.encoding` won't perhaps have the desired effect. > > Setting `file.encoding` via application properties on Daemon startup should work though. You mean, the following has no effect with mvnd 1.0-m7-m40? > > ``` > mvnd.jvmArgs=-Dfile.encoding=ISO-8859-1 > ``` > > I must say it works for me after forcing to start a new daemon via `mvnd --stop`: > > ``` > $ mvnd --stop > $ mvnd -v > Apache Maven Daemon (mvnd) 1.0-m7 linux-amd64 native client (b2ef5d81997adbcdb72dc8c5603722538fa641fe) > Terminal: org.jline.terminal.impl.PosixSysTerminal with pty org.jline.terminal.impl.jansi.linux.LinuxNativePty > Apache Maven 4.0.0-alpha-7 (bf699a388cc04b8e4088226ba09a403b68de6b7b) > Maven home: /home/ppalaga/.sdkman/candidates/mvnd/1.0-m7-m40/mvn > Java version: 17.0.5, vendor: Eclipse Adoptium, runtime: /home/ppalaga/.sdkman/candidates/java/17.0.5-tem > Default locale: en_IE, platform encoding: ISO-8859-1 > OS name: "linux", version: "6.4.11-200.fc38.x86_64", arch: "amd64", family: "unix" > ``` Alright, I got what you mean that mvnd will remain and reuse a certain JVM process, and the defined JVM system properties won't change when running, this may explain why the platform encoding can not be changed before `mvnd --stop`. But I just don't know why it could be changed when running with `mvnd-0.8.2` (the second and third command in my log)? but not be so when running `mvnd-1.0-m7-m40`. Is there any difference in the JVM reusing strategy between these two version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
