[jira] [Commented] (MBUILDCACHE-64) Apply global exclusions to folder names

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760643#comment-17760643
 ] 

ASF GitHub Bot commented on MBUILDCACHE-64:
-------------------------------------------

AlexanderAshitkin commented on code in PR #91:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1310900630


##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -526,6 +603,10 @@ public FileVisitResult visitFileFailed(Path path, 
IOException exc) throws IOExce
         });
     }
 
+    private boolean entryMustBeSkipped(Path path) {
+        return inputExcludePathMatchers.stream().anyMatch(pathMatcher -> 
pathMatcher.matches(path));

Review Comment:
   Right, iteration is over the matchers, not paths 🤦 



##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -526,6 +603,10 @@ public FileVisitResult visitFileFailed(Path path, 
IOException exc) throws IOExce
         });
     }
 
+    private boolean entryMustBeSkipped(Path path) {
+        return inputExcludePathMatchers.stream().anyMatch(pathMatcher -> 
pathMatcher.matches(path));

Review Comment:
   Right, iteration is over the matchers, not paths 🤦 





> Apply global exclusions to folder names
> ---------------------------------------
>
>                 Key: MBUILDCACHE-64
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-64
>             Project: Maven Build Cache Extension
>          Issue Type: Bug
>    Affects Versions: 1.0.1
>            Reporter: Frank Wagner
>            Assignee: Olivier Lamy
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.1.0
>
>
> It is currently not possible to exclude folders by their name, like 
> {quote}<input>
> <global>
> <excludes>
> <exclude>node_modules</exclude>
> <exclude>dist</exclude>
> <exclude>build</exclude>
> </excludes>
> </global>
> ...
> {quote}
> That's because isFilteredOutSubpath(), 
> [https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L638,]
>  uses startWith on normalized absolute paths.
> That function could be enhanced with an additional criterion like in 
> [https://github.com/apache/maven-build-cache-extension/blob/master/src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java#L510]
> {{filteredOutPaths.stream().anyMatch(it -> 
> it.getFileName().equals(entry.getFileName()))}}
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)