[
https://issues.apache.org/jira/browse/MRELEASE-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745070#comment-17745070
]
ASF GitHub Bot commented on MRELEASE-1134:
------------------------------------------
kwin commented on code in PR #197:
URL: https://github.com/apache/maven-release/pull/197#discussion_r1269392285
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/scm/DefaultScmRepositoryConfigurator.java:
##########
@@ -164,7 +164,9 @@ public ScmRepository getConfiguredRepository(String url,
ReleaseDescriptor relea
svnRepo.setBranchBase(branchBase);
}
}
-
+ if (!releaseDescriptor.isInteractive()) {
Review Comment:
Default value is true, the condition is necessary to make the tests pass, as
they rely on the fact that there is no interaction with the mocked provider in
some cases.
> Pass interactive flag to ScmProvider
> ------------------------------------
>
> Key: MRELEASE-1134
> URL: https://issues.apache.org/jira/browse/MRELEASE-1134
> Project: Maven Release Plugin
> Issue Type: Improvement
> Affects Versions: 3.0.1
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
>
> Currently the interactive flag from the ReleaseDescriptor is not passed on to
> SCM, therefore it only has an impact on invocations triggered from the
> release manager directly but not on invocations triggered through SCM.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
