[
https://issues.apache.org/jira/browse/MSITE-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743284#comment-17743284
]
Michael Osipov commented on MSITE-971:
--------------------------------------
[~larrick], interesting, this could be a global issue where {{MavenProject}}
contains global/static values. Can you create a sample project?
Please note that a potential fix needs to be applied to {{AbstractMavenReport}}
as well. Yet another problem is that the Velocity context is populated with
this uninerpolated value. So even if this is fixed, the populated value would
be wrong. I won't want a half-baked solution. Is there a reason why you don't
supply a static value once and have the Maven Release Plugin update the value
for you?
[~gnodet], what is your opinion, this should be this way or should they be
fully interpolated?
> Site generation not resolving git.commit.time
> ---------------------------------------------
>
> Key: MSITE-971
> URL: https://issues.apache.org/jira/browse/MSITE-971
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: property interpolation
> Affects Versions: 4.0.0-M9
> Environment: Windows 10 and FreeBSD
> Reporter: Brad Larrick
> Priority: Major
>
> I'm using git-commit-id-maven-plugin to set project.build.outputTimestamp as
> suggested in the Maven Guide Configuring for Reproducible Builds. I've
> included the plugin in my pom and including the following property definition:
>
> {code:java}
> <project.build.outputTimestamp>${git.commit.time}</project.build.outputTimestamp>{code}
>
> When I generate the site, the plugin fails with the message:
> {{site failed: Invalid project.build.outputTimestamp value
> '${git.commit.time}}}
> This configuration works properly in the maven-jar-plugin, so I did some
> investigation. The jar plugin is getting the outputTimestamp as a mojo
> parameter:
>
> {code:java}
> @Parameter( defaultValue = "${project.build.outputTimestamp}" )
> private String outputTimestamp;
> {code}
> This works properly, with outputTimestamp set to the last commit time.
> In the site-plugin code, the outputTimestamp is being pulled from the project
> properties:
> {code:java}
> String outputTimestamp =
> p.getProperties().getProperty("project.build.outputTimestamp");{code}
> In the case the property hasn't been resolved and the returned string is
> ${git.commit.time}.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
