[GitHub] [maven-site-plugin] gnodet commented on a diff in pull request #155: [MSITE-833] Remove dependency to maven-compat

[via GitHub]

gnodet commented on code in PR #155:
URL: https://github.com/apache/maven-site-plugin/pull/155#discussion_r1232290987


##########
src/test/java/org/apache/maven/plugins/site/deploy/AbstractSiteDeployWebDavTest.java:
##########
@@ -194,15 +194,10 @@ public void davDeployThruProxyWitAuthzInProxy() throws 
Exception {
             if 
(ReflectionUtils.getFieldByNameIncludingSuperclasses("inputDirectory", 
mojo.getClass()) != null) {
                 setVariableValueToObject(mojo, "inputDirectory", 
inputDirectory);
             } else {
-                ArtifactRepositoryFactory artifactRepositoryFactory =
-                        getContainer().lookup(ArtifactRepositoryFactory.class);
-
                 setVariableValueToObject(mojo, "stagingDirectory", 
inputDirectory);
                 setVariableValueToObject(mojo, "reactorProjects", 
Collections.emptyList());
                 setVariableValueToObject(
-                        mojo,
-                        "localRepository",
-                        
artifactRepositoryFactory.createArtifactRepository("local", "foo", "default", 
null, null));
+                        mojo, "localRepository", new 
MavenArtifactRepository("local", "foo", null, null, null));

Review Comment:
   Maybe using `MavenRepositorySystem.createArtifactRepository(...)` instead ?



##########
src/test/java/org/apache/maven/plugins/site/deploy/SiteDeployMojoTest.java:
##########
@@ -30,14 +30,14 @@
  */
 @RunWith(JUnit4.class)
 public class SiteDeployMojoTest extends AbstractMojoTestCase {
-    private WagonManager wagonManager;
+    private Wagon wagon;
 
     // private Repository repository;
 
     @Before
     public void setUp() throws Exception {
         super.setUp();
-        wagonManager = getContainer().lookup(WagonManager.class);
+        // wagon = getContainer().lookup( Wagon.class, "scp" );
         // repository = new Repository( "my-repository", 
"scp://repository-host/var/maven2" );

Review Comment:
   Maybe remove before merging if that's not used anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org