[ https://issues.apache.org/jira/browse/MNG-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733392#comment-17733392 ]
ASF GitHub Bot commented on MNG-7814: ------------------------------------- cstamas commented on code in PR #1164: URL: https://github.com/apache/maven/pull/1164#discussion_r1231935562 ########## api/maven-api-settings/src/main/java/org/apache/maven/api/settings/InputSource.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api.settings; + +import java.io.Serializable; + +/** + * Class InputSource. + */ +public class InputSource implements Serializable { + + private final String location; + + public InputSource(String location) { + this.location = location; + } + + /** + * Get the path/URL of the POM or {@code null} if unknown. Review Comment: minirO of the POM? ########## api/maven-api-settings/src/main/java/org/apache/maven/api/settings/InputSource.java: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api.settings; + +import java.io.Serializable; + +/** + * Class InputSource. + */ +public class InputSource implements Serializable { + + private final String location; + + public InputSource(String location) { + this.location = location; + } + + /** + * Get the path/URL of the POM or {@code null} if unknown. Review Comment: minor: fO of the POM? > Use location tracking for settings > ---------------------------------- > > Key: MNG-7814 > URL: https://issues.apache.org/jira/browse/MNG-7814 > Project: Maven > Issue Type: New Feature > Reporter: Guillaume Nodet > Assignee: Guillaume Nodet > Priority: Major > Fix For: 4.0.x-candidate > > > We do have all the code needed to track settings location in a similar way > than we do for the model. -- This message was sent by Atlassian Jira (v8.20.10#820010)