hboutemy commented on code in PR #155: URL: https://github.com/apache/maven-apache-parent/pull/155#discussion_r1215272323
########## pom.xml: ########## @@ -96,6 +96,34 @@ under the License. <surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and surefire-report --> <maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for m-plugin-p and maven-plugin-annotations --> <assembly.tarLongFileMode>posix</assembly.tarLongFileMode> + + <!-- plugins versions --> + <apacheRatPluginVersion>0.15</apacheRatPluginVersion> + <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion> + <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion> + <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion> + <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion> + <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion> + <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion> + <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion> + <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion> + <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion> + <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion> + <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion> + <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion> + <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion> + <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion> + <mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion> + <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion> + <mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion> + <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion> + <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion> + <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion> + <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion> + <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion> + <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion> + <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion> Review Comment: - camelCase for such properties is really unusual to many, and *much harder to read* than having a real separator (dot, underscore, dash); Choosing camelCase only for .vm simplification looks IMHO a bad compromise - whatever the convention for splitting fields, having version as first field for sortability seems a very good idea - on plugin field: is there an issue with using direct artifactId? - remember that this PR introduces new properties that many ASF child projects will later use to override: changing the names later will cause much friction, then the choice has to be well thought -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org