[ 
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721104#comment-17721104
 ] 

ASF GitHub Bot commented on MNG-6829:
-------------------------------------

timtebeek commented on PR #214:
URL: 
https://github.com/apache/maven-plugin-tools/pull/214#issuecomment-1540970621

   > Buit not gone from the POM, no?
   
   We're not at the stage yet where we have removed all methods of StringUtils, 
so we can't yet remove the dependency. See for instance 
https://github.com/apache/maven-plugin-tools/blob/73791dd14fab1f974bab6415b074835945336728/maven-script/maven-script-ant/src/main/java/org/apache/maven/script/ant/AntMojoWrapper.java#L209-L210
   
   As requested I'm doing small individual (automated) changes, such that they 
are easier to review and merge, with less risk.
   We hope to get to fully removing StringUtils soon, but feel free to help out 
either in an automated fashion, or by cleaning up what remains after the first 
few rounds.




> Remove commons-lang3 dependency
> -------------------------------
>
>                 Key: MNG-6829
>                 URL: https://issues.apache.org/jira/browse/MNG-6829
>             Project: Maven
>          Issue Type: Sub-task
>          Components: Bootstrap & Build
>    Affects Versions: 3.6.3
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>              Labels: close-pending
>             Fix For: 4.0.x-candidate
>
>         Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or 
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by 
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can 
> be implemented very easily (done already to see how it works). Later this 
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName,  "/" )}} is 
> used in {{ConsoleMavenTransferListener}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to