[ 
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721099#comment-17721099
 ] 

ASF GitHub Bot commented on MNG-6829:
-------------------------------------

timtebeek commented on PR #1104:
URL: https://github.com/apache/maven/pull/1104#issuecomment-1540940738

   Some of these remove imports though right? But only when there's no other 
methods being called. There's quite a few `StringUtils.replace` that I'd like 
to tackle next, which should help remove further imports.
   
   I'd not reconsidered replacing imports yet (going from one string utils 
implementation to another), as it seemed removing was preferred over 
replacement. Is that still the case?
   
   We can discuss what to tackle next and how to approach things going forward, 
as there were other concerns as well such as matching up per project Jira 
issues. Perhaps we can schedule a brief call or chat at a conference to discuss?




> Remove commons-lang3 dependency
> -------------------------------
>
>                 Key: MNG-6829
>                 URL: https://issues.apache.org/jira/browse/MNG-6829
>             Project: Maven
>          Issue Type: Sub-task
>          Components: Bootstrap & Build
>    Affects Versions: 3.6.3
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>              Labels: close-pending
>             Fix For: 4.0.x-candidate
>
>         Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or 
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by 
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can 
> be implemented very easily (done already to see how it works). Later this 
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName,  "/" )}} is 
> used in {{ConsoleMavenTransferListener}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to