michael-o commented on PR #1061: URL: https://github.com/apache/maven/pull/1061#issuecomment-1511943122
> > I think as far as @elharo's comments are concerned, he's right. Names should be written out, i.e., `getRootDirectory()`, `getTopDirectory()`, etc. > > Should that imply that the properties become `project.rootDirectory`, `session.rootDirectory` and `session.topDirectory` ? I think people are used to `basedir` so I wanted to align with it and make things coherent. If so, I'd rename that one to `project.baseDirectory` too. I wouldn't touch the properties, only Java code. But if the properties *map* to Java code, then this is a problem, of course. Is this the case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
