elharo commented on code in PR #1080:
URL: https://github.com/apache/maven/pull/1080#discussion_r1158836557
##########
maven-core/src/main/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformation.java:
##########
@@ -90,7 +88,9 @@ private String loadMavenVersion() {
@Override
public boolean isMavenVersion(String versionRange) {
- Validate.notBlank(versionRange, "versionRange can neither be null,
empty nor blank");
+ if (!(versionRange != null && !versionRange.isEmpty())) {
+ throw new IllegalArgumentException("versionRange can neither be
null nor empty");
Review Comment:
better to use a NullPointerException for null. The tests below suggest this
was the existing behavior.
##########
maven-core/src/main/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformation.java:
##########
@@ -90,7 +88,9 @@ private String loadMavenVersion() {
@Override
public boolean isMavenVersion(String versionRange) {
- Validate.notBlank(versionRange, "versionRange can neither be null,
empty nor blank");
+ if (!(versionRange != null && !versionRange.isEmpty())) {
Review Comment:
slightly clearer:
```
if (versionRange == null || versionRange.isEmpty())
```
##########
maven-artifact/pom.xml:
##########
@@ -30,12 +30,7 @@ under the License.
<name>Maven Artifact</name>
- <dependencies>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-lang3</artifactId>
- </dependency>
- </dependencies>
+ <dependencies />
Review Comment:
do we need the empty element or can we just drop it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
