[ 
https://issues.apache.org/jira/browse/MPMD-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708897#comment-17708897
 ] 

Elliotte Rusty Harold commented on MPMD-367:
--------------------------------------------

I think the warning is exactly this breakage. What happens is that the 
integration tests are configured to fail if the logs contain the string 
"[WARNING]". They're checking to make sure that a particular PMD check does not 
generate a warning. However, they pick up this warning too and thus fail.

My question  is why did this happen outside the normal chain of PRs? That is, 
it looks like the CI config is outside the repo and a change to the CI config — 
e.g. updating to a new Maven version — can cause tests to start failing that 
were previously passing. 

> Verify / ubuntu-latest jdk-11-temurin 3.9.1 broken at head in 
> MPMD-270-325-JDK11
> --------------------------------------------------------------------------------
>
>                 Key: MPMD-367
>                 URL: https://issues.apache.org/jira/browse/MPMD-367
>             Project: Maven PMD Plugin
>          Issue Type: Task
>            Reporter: Elliotte Rusty Harold
>            Assignee: Elliotte Rusty Harold
>            Priority: Major
>
> Problem seems to be that this test produces a WARNING on this platform (and 
> only this platform?) that fails the build
> {noformat}
> 317 kB at 5.4 MB/s)
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 2 source files to 
> /home/runner/work/maven-pmd-plugin/maven-pmd-plugin/target/it/MPMD-270-325-JDK11/target/classes
> [INFO] 
> [INFO] --- resources:3.3.0:testResources (default-testResources) @ 
> MPMD-270-325-JDK11 ---
> [INFO] skip non existing resourceDirectory 
> /home/runner/work/maven-pmd-plugin/maven-pmd-plugin/target/it/MPMD-270-325-JDK11/src/test/resources
> [INFO] 
> [INFO] --- compiler:3.8.0:testCompile (default-testCompile) @ 
> MPMD-270-325-JDK11 ---
> [INFO] No sources to compile
> [INFO] 
> [INFO] --- surefire:3.0.0:test (default-test) @ MPMD-270-325-JDK11 ---
> [INFO] No tests to run.
> [INFO] 
> [INFO] --- jar:3.3.0:jar (default-jar) @ MPMD-270-325-JDK11 ---
> [INFO] Building jar: 
> /home/runner/work/maven-pmd-plugin/maven-pmd-plugin/target/it/MPMD-270-325-JDK11/target/MPMD-270-325-JDK11-1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] >>> pmd:3.21.0-SNAPSHOT:check (default) > :pmd @ MPMD-270-325-JDK11 >>>
> [INFO] 
> [INFO] --- pmd:3.21.0-SNAPSHOT:pmd (pmd) @ MPMD-270-325-JDK11 ---
> [WARNING] Parameter \'localRepository\' is deprecated core expression; Avoid 
> use of ArtifactRepository type. If you need access to local repository, 
> switch to \'${repositorySystemSession}\' expression and get LRM from it 
> instead.
> [INFO] PMD version: 6.55.0
> [INFO] Rendering content with 
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [INFO] 
> [INFO] <<< pmd:3.21.0-SNAPSHOT:check (default) < :pmd @ MPMD-270-325-JDK11 <<<
> [INFO] 
> [INFO] 
> [INFO] --- pmd:3.21.0-SNAPSHOT:check (default) @ MPMD-270-325-JDK11 ---
> [INFO] PMD version: 6.55.0
> [INFO] PMD Failure: com.mycompany.app.Foo:26 Rule:UnusedFormalParameter 
> Priority:3 Avoid unused constructor parameters such as \'foo\'..
> [INFO] 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to