[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708249#comment-17708249
]
ASF GitHub Bot commented on MNG-6825:
-------------------------------------
timtebeek commented on PR #832:
URL: https://github.com/apache/maven-mvnd/pull/832#issuecomment-1495431882
HI @gnodet . Yes I certainly strive to get rid of these calls where I can in
the near future, and where the Java language level allows us to do so
effectively. Such transformations can (mostly) be automated as well, which is
the only way to feasibly do this across 89 repositories. But before we can
apply such further automations it helps to first standardize on one variant of
StringUtils, rather than the mix of three we have currently. Otherwise we would
have to duplicate effort in detecting and migrating method calls, with recipes
and change sets more difficult to reason about, and reviews that might require
thought rather than clear one to one migrations.
It's best to see this as an ongoing effort of modernization, rather than the
intended end state. In
[MNG-6825](https://issues.apache.org/jira/browse/MNG-6825) I was asked to
create small, easy to reason about PRs, at first going to commons-lang3, and
then following that up once we've weened ourselves off of plexus-utils &
maven-shared-utils as much as possible.
This PR is one of fifty for this set of change recipes to move towards
commons-lang3 at first. I agree that for some projects this can result in a
small change set that on it's own isn't adding a lot of value at this time. Yet
it's also a necessary step before we can apply more advanced automated
migrations across the board such as replacing some of the methods that you've
suggested with JDK internals.
Given the above, do you then agree to apply these changes, and others like
this, as they are right now?
Alternatively it's also possible to incidentally migrate individual projects
towards JDK internals manually already. The automations I'm applying will only
trigger when an exact match is found. I do not hope or intend to make a lot of
such manual changes myself.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> ---------------------------------------------------------------------------------
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
