gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1152011959
##########
maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java:
##########
@@ -1051,16 +1057,44 @@ public MavenExecutionRequest setToolchains(Map<String,
List<ToolchainModel>> too
return this;
}
+ @Deprecated
@Override
public void setMultiModuleProjectDirectory(File directory) {
this.multiModuleProjectDirectory = directory;
}
+ @Deprecated
@Override
public File getMultiModuleProjectDirectory() {
return multiModuleProjectDirectory;
}
+ @Override
+ public Path getRootdir() {
+ if (rootdir == null) {
+ throw new IllegalArgumentException("Unable to find the root
directory. "
Review Comment:
The goal is to throw an exception when actually used. So it's not a hard
requirement unless you actually use it somehow in a plugin or in a model, in
which case, yes, it becomes a hard requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
