gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1152003319


##########
maven-model-builder/src/site/apt/index.apt:
##########
@@ -192,6 +192,10 @@ Maven Model Builder
 *----+------+------+
 | <<<maven.home>>> | The path to the current Maven home. | 
<<<$\{maven.home\}>>> |
 *----+------+------+
+| <<<maven.rootdir>>> | the directory containing the root <<<pom.xml>>> file 
of a multi module project, in a single module project this is the same as 
<<<project.basedir>>> | <<<$\{maven.rootdir\}>>> |
+*----+------+------+
+| <<<maven.topdir>>> | the directory containing the top-level <<<pom.xml>>> in 
this reactor build | <<<$\{maven.topdir\}>>> |
+*----+------+------+

Review Comment:
   `topdir` is not really new, it's mostly a rename of the `executionRootDir` 
property to make it more coherent with `basedir` and `rootdir`, else we end up 
with `root directory` and `execution root directory` for different things, and 
that will definitely lead to problems imho.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to