olamy commented on code in PR #617:
URL: https://github.com/apache/maven-surefire/pull/617#discussion_r1130019507
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireDependencyResolver.java:
##########
@@ -59,7 +62,10 @@
* @author Stephen Connolly
* @author Kristian Rosenvold
*/
-final class SurefireDependencyResolver {
+@Named
+@Singleton
+public class SurefireDependencyResolver {
Review Comment:
Thanks!
Not sure why "the best way"? do you plan to introduce alternate
implementations?
so no need to introduce interface for a package private class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
