cstamas commented on code in PR #266: URL: https://github.com/apache/maven-resolver/pull/266#discussion_r1127758035
########## src/site/markdown/configuration.md: ########## @@ -41,6 +41,7 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preemptivePutAuth` | boolean | Should HTTP client use preemptive-authentication for HTTP PUTs only (works only w/ BASIC). By default is enabled (same as Wagon). | `true` | yes `aether.connector.http.retryHandler.count` | int | The maximum number of times a request to a remote HTTP server should be retried in case of an error. | `3` | yes `aether.connector.http.supportWebDav` | boolean | If enabled, transport makes best effort to deploy to WebDAV server. This mode is not recommended, better use real Maven Repository Manager instead. | `false` | yes +`aether.connector.http.useSystemProperties` | boolean | If enabled, underlying Apache HttpClient will use system properties as well to configure itself (typically used to set up HTTP Proxy via Java system properties). This mode is not recommended, better use proper Maven configuration means instead. | `false` | yes Review Comment: Originally I wanted to WARN if `proxy != null` (set few lines above), but this builder option is NOT ONLY about proxy but many many other things. Hence the hint "typically used..." as I cannot nor I want to commit to any guarantees here. Simply put: if this option used, user should use it only for "typically set" stuff, and ensure the code is doing what he things is doing. The reason of existence of this PR is ONLY to allow use of transport-http for use case like https://issues.apache.org/jira/browse/MNG-7721 where user defines only 5 http proxy related properties. Given when this enabled, httpClient OBEY MANY system properties, and we CANNOT control which one it obeys, this is the cleanest. This PR will work for reporter of MNG-7721 but I have no idea for other use cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
