kwin commented on code in PR #266: URL: https://github.com/apache/maven-resolver/pull/266#discussion_r1127754033
########## src/site/markdown/configuration.md: ########## @@ -41,6 +41,7 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preemptivePutAuth` | boolean | Should HTTP client use preemptive-authentication for HTTP PUTs only (works only w/ BASIC). By default is enabled (same as Wagon). | `true` | yes `aether.connector.http.retryHandler.count` | int | The maximum number of times a request to a remote HTTP server should be retried in case of an error. | `3` | yes `aether.connector.http.supportWebDav` | boolean | If enabled, transport makes best effort to deploy to WebDAV server. This mode is not recommended, better use real Maven Repository Manager instead. | `false` | yes +`aether.connector.http.useSystemProperties` | boolean | If enabled, underlying Apache HttpClient will use system properties as well to configure itself (typically used to set up HTTP Proxy via Java system properties). This mode is not recommended, better use proper Maven configuration means instead. | `false` | yes Review Comment: I wouldn’t expect the term Maven configuration in here. Rather resolver configuration as resolver can still be used outside Maven ########## src/site/markdown/configuration.md: ########## @@ -41,6 +41,7 @@ Option | Type | Description | Default Value | Supports Repo ID Suffix `aether.connector.http.preemptivePutAuth` | boolean | Should HTTP client use preemptive-authentication for HTTP PUTs only (works only w/ BASIC). By default is enabled (same as Wagon). | `true` | yes `aether.connector.http.retryHandler.count` | int | The maximum number of times a request to a remote HTTP server should be retried in case of an error. | `3` | yes `aether.connector.http.supportWebDav` | boolean | If enabled, transport makes best effort to deploy to WebDAV server. This mode is not recommended, better use real Maven Repository Manager instead. | `false` | yes +`aether.connector.http.useSystemProperties` | boolean | If enabled, underlying Apache HttpClient will use system properties as well to configure itself (typically used to set up HTTP Proxy via Java system properties). This mode is not recommended, better use proper Maven configuration means instead. | `false` | yes Review Comment: Can you state which one takes precedence in case both are set? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
