ppalaga commented on code in PR #797:
URL: https://github.com/apache/maven-mvnd/pull/797#discussion_r1123228141
##########
common/src/main/java/org/mvndaemon/mvnd/common/Environment.java:
##########
@@ -163,6 +163,12 @@ public enum Environment {
* non-native clients and is useful mostly for debugging.
*/
MVND_NO_DAEMON("mvnd.noDaemon", "MVND_NO_DAEMON", Boolean.FALSE,
OptionType.BOOLEAN, Flags.DISCRIMINATING),
+
+ /**
+ * If <code>true</code>, the daemon will not use its in-memory metadata
cache and instead re-read the
+ * metadata from the pom.xml files in the local repository. This is mostly
useful for testing purposes.
+ */
+ MVND_NO_MODEL_CACHE("mvnd.noModelCache", null, Boolean.FALSE,
OptionType.BOOLEAN, Flags.NONE),
Review Comment:
I wonder whether we should use `Flags.DISCRIMINATING`? Is the
`createCache()` method called once for a given daemon instance or once per
Maven build?
If it's once for daemon, I'd say it should be `Flags.DISCRIMINATING`.
Otherwise it could happen that the user starts the daemon with `mvnd
-Dmvnd.noModelCache` and all subsequent `mvnd` invocations with *or without*
`-Dmvnd.noModelCache` will be served by the same daemon instance that has model
cache off. That would not be correct, would it?
`Flags.DISCRIMINATING` will make all calls with `-Dmvnd.noModelCache` be
served by a cacheless instance while all calls without `-Dmvnd.noModelCache`
will be served by some other daemon instance that has the cache enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
