[ 
https://issues.apache.org/jira/browse/MNG-7605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681929#comment-17681929
 ] 

Christoph Läubrich edited comment on MNG-7605 at 1/30/23 8:33 AM:
------------------------------------------------------------------

1. 
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/ReactorReader.java
2. Code uses "type" of artifact: 
https://github.com/apache/maven/blob/fbeefb85abdc1e6d42e06c4438951d2a38d4b383/maven-core/src/main/java/org/apache/maven/ReactorReader.java#L181

ArtifactHandler (isAddToClasspath / isIncludeDependecies) where probably new 
isIncludeCompilePhase() would be added:
https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java


was (Author: laeubi):
1. 
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/ReactorReader.java
2. Code uses "type" of artifact: 
https://github.com/apache/maven/blob/fbeefb85abdc1e6d42e06c4438951d2a38d4b383/maven-core/src/main/java/org/apache/maven/ReactorReader.java#L181

> ArtifactHandler should include a method to check if this one has a compile 
> phase
> --------------------------------------------------------------------------------
>
>                 Key: MNG-7605
>                 URL: https://issues.apache.org/jira/browse/MNG-7605
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> Currently ReactorReader has a hardcoded list of types that have a "compile" 
> phase where a reactor project is resolved to the output directory.
> Instead of a hardcoded list, it would be better to ask the available 
> ArtifactHandler about this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to