[
https://issues.apache.org/jira/browse/MNG-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677659#comment-17677659
]
ASF GitHub Bot commented on MNG-7664:
-------------------------------------
michael-o commented on PR #949:
URL: https://github.com/apache/maven/pull/949#issuecomment-1384998905
> > Wouldn't be shared resources module better than `${basedir}/..` magic?
>
> What would be the benefit of creating an additional module and publishing
the artifact if it's purely internal ? Also, I think the fact that velocity
templates are used means that the templates need to be on the filesystem, which
means extracting them before running modello. That sounds a bit complicated
imho...
First of all, the deployment can be skipped. I remember that in this exact
situation we recommend users to share a module in reactor instead of dealing
with path traversal. Of course, it is a bit more work. The result is the same.
I will leave the decision to @hboutemy .
> consolidate Velocity templates used to generate code from models
> ----------------------------------------------------------------
>
> Key: MNG-7664
> URL: https://issues.apache.org/jira/browse/MNG-7664
> Project: Maven
> Issue Type: Task
> Affects Versions: 4.0.0-alpha-3
> Reporter: Herve Boutemy
> Priority: Major
> Fix For: 4.0.0-alpha-4
>
>
> current .vm files with same names are copied with different content:
> - common.vm: 7 copies with 2 versions
> - merger.vm: 4 copies with 3 versions
> - model-v3.vm: 3 copies with 2 versions
> - model.vm: 4 copies with 2 versions
> - reader.vm: 4 copies with 3 versions
> - writer.vm: 4 copies with 2 versions
> we need to have one single source of truth for each .vm, or if there is a
> good reason to have different content, clearly have different file names
> reference:
> {noformat}
> $ for f in $(find * -wholename "*/mdo/*.vm") ; do echo "$(basename
> $f)\t$(sha1sum $f)"; done | sort
> common.vm 31c55d1da70a4310e1bcb7302452448aff2d70ae
> maven-model/src/main/mdo/common.vm
> common.vm 34d07b71853f03c375c56b502029ee43e160d38c
> api/maven-api-model/src/main/mdo/common.vm
> common.vm 73b0a4b0f6ad6c1c9842d07260dbbb620834164c
> api/maven-api-settings/src/main/mdo/common.vm
> common.vm 73b0a4b0f6ad6c1c9842d07260dbbb620834164c
> api/maven-api-toolchain/src/main/mdo/common.vm
> common.vm 73b0a4b0f6ad6c1c9842d07260dbbb620834164c
> maven-plugin-api/src/main/mdo/common.vm
> common.vm 73b0a4b0f6ad6c1c9842d07260dbbb620834164c
> maven-settings/src/main/mdo/common.vm
> common.vm 73b0a4b0f6ad6c1c9842d07260dbbb620834164c
> maven-toolchain-model/src/main/mdo/common.vm
> merger.vm 23708e59e2d72ac18690812f1e24a24ca1d114de
> maven-plugin-api/src/main/mdo/merger.vm
> merger.vm ca81ca51b7b92d8bde8efaae7a876a5814d445eb
> maven-model/src/main/mdo/merger.vm
> merger.vm dcb28fc758348aaf141bcabb948b684a02278b53
> maven-settings/src/main/mdo/merger.vm
> merger.vm dcb28fc758348aaf141bcabb948b684a02278b53
> maven-toolchain-model/src/main/mdo/merger.vm
> model-v3.vm 44731b71907aa8328bfab481fec195949725d787
> maven-model/src/main/mdo/model-v3.vm
> model-v3.vm 48c07c004ec17f7207c768c49e7b212da42b89c4
> maven-settings/src/main/mdo/model-v3.vm
> model-v3.vm 48c07c004ec17f7207c768c49e7b212da42b89c4
> maven-toolchain-model/src/main/mdo/model-v3.vm
> model.vm 0fb62cd6a2cb486e5c6fbc17423cd72b375321f1
> maven-plugin-api/src/main/mdo/model.vm
> model.vm bbb9ec6a7b9a073144645635c636649b1663fb96
> api/maven-api-model/src/main/mdo/model.vm
> model.vm bbb9ec6a7b9a073144645635c636649b1663fb96
> api/maven-api-settings/src/main/mdo/model.vm
> model.vm bbb9ec6a7b9a073144645635c636649b1663fb96
> api/maven-api-toolchain/src/main/mdo/model.vm
> reader-ex.vm 52992ae7704cd37fa8719c5f70bf408f653c0655
> maven-model/src/main/mdo/reader-ex.vm
> reader.vm 350fa92d0b73eb9f8ca8c392ce051adcf84e0b47
> maven-plugin-api/src/main/mdo/reader.vm
> reader.vm 36b89e2589dc46a9fe1fb062487dec520a48912b
> maven-model/src/main/mdo/reader.vm
> reader.vm f47c5c5946884ab65ced6fae888e9257672e27a9
> maven-settings/src/main/mdo/reader.vm
> reader.vm f47c5c5946884ab65ced6fae888e9257672e27a9
> maven-toolchain-model/src/main/mdo/reader.vm
> transformer.vm 64ce52293a80bef09d94d7df099557f11a97cd21
> maven-model/src/main/mdo/transformer.vm
> writer-ex.vm 3a06d583d4ec12a139e7b036ae89556d1e4df222
> maven-model/src/main/mdo/writer-ex.vm
> writer.vm 0050b576e4b4f0b0ad39df6bdeda9ed1f64ab379
> maven-model/src/main/mdo/writer.vm
> writer.vm 0050b576e4b4f0b0ad39df6bdeda9ed1f64ab379
> maven-settings/src/main/mdo/writer.vm
> writer.vm 0050b576e4b4f0b0ad39df6bdeda9ed1f64ab379
> maven-toolchain-model/src/main/mdo/writer.vm
> writer.vm 1b600282b320af2d87e2c9eade32bb150ad85699
> maven-plugin-api/src/main/mdo/writer.vm
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
