[GitHub] [maven] hboutemy commented on a diff in pull request #949: [MNG-7664] consolidate Velocity templates used to generate code from models

Tue, 17 Jan 2023 00:12:28 -0800 


hboutemy commented on code in PR #949:
URL: https://github.com/apache/maven/pull/949#discussion_r1071880277


##########
maven-plugin-api/pom.xml:
##########
@@ -92,6 +94,7 @@ under the License.
             </goals>
             <phase>pre-site</phase>
             <configuration>
+              <basedir>${basedir}</basedir>

Review Comment:
   given it's not used with the Velocity-based generators, I think this would 
create even more confusion than the current situation where Velocity-based 
generation is used only on some .mdo but not all



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to