[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676964#comment-17676964
 ] 
Michael Osipov edited comment on DOXIASITETOOLS-278 at 1/15/23 1:58 AM:
------------------------------------------------------------------------

OK, created a PR. It works. Now, there are two ways to solve that:
1. Skip entry when module site is skipped
2. Leave entry, but don't like since there is not site (benefit: you know that 
the module exists)

Option two triggers a bug in Maven Fluido Skin, but the fix is trivial.

I prefer option 2 for the same of completeness. This 
(https://maven.apache.org/plugins/maven-project-info-reports-plugin/modules-mojo.html)
 lists all modules and it would be awkward if I'd leave them physically out. 
They have to be consistent.

WDYT?


was (Author: michael-o):
OK, created a PR. It works. Now, there are two ways to solve that:
1. Skip entry when module site is skipped
2. Leave entry, but don't like since there is not site (benefit: you know that 
the module exists)

Option two triggers a bug in Maven Fluido Skin, but the fix is trivial.

I prefer option 2 for the same of completeness.

WDYT?

> Remove menu items link in the side bar to sub module that do not generate any 
> site in the same build
> ----------------------------------------------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-278
>                 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-278
>             Project: Maven Doxia Sitetools
>          Issue Type: Improvement
>          Components: Integration Tools
>    Affects Versions: 2.0.0-M4
>         Environment: Windows7, Maven 3.3.9
>            Reporter: Nikolas Falco
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M5
>
>
> We have some multi-module projects where a few modules are only for scope 
> distribution or for integration test.
> These modules are marked with maven.site.skip=true and the site is not 
> generated, but in the maven site of parent project they appear in the sidebar 
> menu, clearly if you click on those links are broken.
> Debugging the code, the mojo loop on each project in the reactor build and 
> add as menu item.
> Is possible add a configuration element of maven-site-plugin to exclude some 
> modules from the modules report menu? or implement a check if a site for that 
> project exists?
> org.example
>  |- module1
>  |- module2
>  |- module.test (skip generation)
>  |- distribution (skip generation)
> the maven site of org.example have in the menu bar links to no available site 
> of distribution and module.test



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to