gnodet commented on code in PR #866:
URL: https://github.com/apache/maven/pull/866#discussion_r1061225506
##########
maven-xml-impl/src/main/java/org/apache/maven/internal/xml/Xpp3Dom.java:
##########
@@ -180,8 +181,6 @@ public void writeToSerializer(String namespace,
XmlSerializer serializer) throws
* </ol></li>
* <li> If mergeSelf == true
* <ol type="A">
- * <li> if the dominant root node's value is empty, set it to the
recessive root node's value</li>
- * <li> For each attribute in the recessive root node which is not set
in the dominant root node, set it.</li>
Review Comment:
@guylabs I'm not really the author of the change, I simply back ported it
because the code is duplicated somehow from plexus-utils. The original change
is
https://github.com/codehaus-plexus/plexus-utils/commit/67ac243dbc6434c03a9b1582d94aef6bf2b5cf95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
