psiroky commented on PR #223: URL: https://github.com/apache/maven-integration-testing/pull/223#issuecomment-1370261138
Once I had these changes done I noticed @slawekjaranowski solved this a bit differently in `maven-enforcer` (https://github.com/apache/maven-enforcer/commit/74228deccd43ec88dadf59fa70d98dfd5ead33c5), by adding the `<scope>provided</scope> into `dependencyManagement`. For some reason I thought that having `scope` inside `dependencyManagement` is not a good practice (with the exception of BOM `import`) as it should just define the version and then modules using that dependency should decide which scope is appropriate for that specific use case. That being said, in this case it actually makes sense as we want these always provided for the IT plugins. If preferred, I can amend the PR with similar changes leveraging `dependencyManagement`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
