[ 
https://issues.apache.org/jira/browse/MNG-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648983#comment-17648983
 ] 

ASF GitHub Bot commented on MNG-7637:
-------------------------------------

laeubi opened a new pull request, #921:
URL: https://github.com/apache/maven/pull/921

   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG-7637) filed
          for the change (usually before you start working on it).  Trivial 
changes like typos do not
          require a JIRA issue. Your pull request should address just this 
issue, without
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you 
replace `MNG-XXX`
          and `SUMMARY` with the appropriate JIRA issue. Best practice is to 
use the JIRA issue
          title in the pull request title and in the first line of the commit 
message.
    - [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
          be performed on your pull request automatically.
    - [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   




> NPE in MavenProject#hashCode if erornous xml
> --------------------------------------------
>
>                 Key: MNG-7637
>                 URL: https://issues.apache.org/jira/browse/MNG-7637
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.8.6, 4.0.0-alpha-3
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> org.apache.maven.project.MavenProject.hashCode() has the following code:
> {code:java}
> public int hashCode()
>     {
>         int hash = 17;
>         hash = 31 * hash + getGroupId().hashCode();
>         hash = 31 * hash + getArtifactId().hashCode();
>         hash = 31 * hash + getVersion().hashCode();
>         return hash;
>     }
> {code}
> if any of those values is null, a NPE is thrown from the method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to