[
https://issues.apache.org/jira/browse/MNG-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647890#comment-17647890
]
ASF GitHub Bot commented on MNG-7626:
-------------------------------------
gnodet commented on code in PR #910:
URL: https://github.com/apache/maven/pull/910#discussion_r1049297555
##########
maven-bom/pom.xml:
##########
@@ -18,14 +17,13 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
-
<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd";>
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven-parent</artifactId>
- <version>35</version>
- <relativePath />
+ <version>38</version>
+ <relativePath/>
Review Comment:
If the problem is that the parent contains too much stuff, I still think it
would be better to use the parent, and maybe create another pom to contain all
the definitions used at build time and have other modules inherit from that one.
> maven-bom should have the same parent version as project
> --------------------------------------------------------
>
> Key: MNG-7626
> URL: https://issues.apache.org/jira/browse/MNG-7626
> Project: Maven
> Issue Type: Task
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
