gnodet commented on code in PR #910: URL: https://github.com/apache/maven/pull/910#discussion_r1049297555
########## maven-bom/pom.xml: ########## @@ -18,14 +17,13 @@ KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> - <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> <modelVersion>4.0.0</modelVersion> <parent> <groupId>org.apache.maven</groupId> <artifactId>maven-parent</artifactId> - <version>35</version> - <relativePath /> + <version>38</version> + <relativePath/> Review Comment: If the problem is that the parent contains too much stuff, I still think it would be better to use the parent, and maybe create another pom to contain all the definitions used at build time and have other modules inherit from that one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
