[
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644629#comment-17644629
]
Herve Boutemy commented on MSHARED-480:
---------------------------------------
another aspect that this now makes clear, and I was struggling to explain my
feeling until now (I now see why...): on sections titles and the change to have
Doxia section 1 rendered with h1 instead of h2 previously, which seemed crazy
Here, it proves why section 1 to HTML h2 was not crazy: as you can see, there
is the title of the page ("Active DNS Locator" in your example) that is
rendered in the header section of the HTML output (by the skin...)
i don't know of the skin renders the title as h1 or as another malrkup, but the
(unsaid until now) reasoning of the historic choice of rendering section 1 to
h2 was to have this title as h1 (in old skins, I suppose).
We'll need to discuss on that again, i suppose, now that I was able to clarify
the historical reasoning...
definitely, this new rendering clarifies a lot the page content vs the site
"decoration" from Doxia Siterenderer with its skins
> Use maven-site-plugin's site.xml to use site's skin instead of default when
> run as mojo
> ---------------------------------------------------------------------------------------
>
> Key: MSHARED-480
> URL: https://issues.apache.org/jira/browse/MSHARED-480
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
> Affects Versions: maven-reporting-impl 2.4
> Reporter: Herve Boutemy
> Assignee: Michael Osipov
> Priority: Minor
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png
>
>
> currently, when a reporting mojo is not used as maven-site-plugin's report
> but as direct mojo invocation, maven-site-renderer default skin is always
> used: would be more consistent if using site decoration consistently with
> maven-site-plugin
> Or more precisely, I didn't currently find any reporting plugin that did the
> effort to mimic maven-site-plugin's decoration model/skin: every reporting
> plugin I know of uses features of {{maven-reporting-impl}} for site rendring
> (with this known limitation)
> implementing the feature in {{maven-reporting-impl}} will make it accessible
> to any reporting plugin once it upgrades it dependency version
> once done, we can activate skin resources copy, that was commented while
> working on MSHARED-120 (and would not give expected result if skin used is
> not consistent)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
