[ 
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643783#comment-17643783
 ] 

Michael Osipov commented on MSHARED-480:
----------------------------------------

Here is a comparison from my project:
With Maven Site Plugin:
 !screenshot-1.png! 
Direct invocation after the fix:
 !screenshot-2.png! 

Don't mind the heading size, this needs to be fixed in Fluido. The menu is 
correct since the menu is also populated by the Maven Site Plugin.
>From my opion the menu on the side or top is useless:
 !screenshot-3.png! 

>From Fluido Skin we need to internally set this:
{noformat}
 34   <custom>
 35     <fluidoSkin>
 36       <topBarEnabled>true</topBarEnabled>
 37       <sideBarEnabled>true</sideBarEnabled>
 38     </fluidoSkin>
 39   </custom>
{noformat}

and the result:
 !screenshot-4.png! 

Note: Now the context contains the information about standalone execution so we 
can distinguish.


> Use maven-site-plugin's site.xml to use site's skin instead of default when 
> run as mojo
> ---------------------------------------------------------------------------------------
>
>                 Key: MSHARED-480
>                 URL: https://issues.apache.org/jira/browse/MSHARED-480
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-reporting-impl
>    Affects Versions: maven-reporting-impl 2.4
>            Reporter: Herve Boutemy
>            Assignee: Michael Osipov
>            Priority: Minor
>         Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, 
> screenshot-4.png
>
>
> currently, when a reporting mojo is not used as maven-site-plugin's report 
> but as direct mojo invocation, maven-site-renderer default skin is always 
> used: would be more consistent if using site decoration consistently with 
> maven-site-plugin
> Or more precisely, I didn't currently find any reporting plugin that did the 
> effort to mimic maven-site-plugin's decoration model/skin: every reporting 
> plugin I know of uses features of {{maven-reporting-impl}} for site rendring 
> (with this known limitation)
> implementing the feature in {{maven-reporting-impl}} will make it accessible 
> to any reporting plugin once it upgrades it dependency version
> once done, we can activate skin resources copy, that was commented while 
> working on MSHARED-120 (and would not give expected result if skin used is 
> not consistent)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to