[ 
https://issues.apache.org/jira/browse/MPLUGIN-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619090#comment-17619090
 ] 
ASF GitHub Bot commented on MPLUGIN-419:
----------------------------------------

kwin commented on code in PR #151:
URL: https://github.com/apache/maven-plugin-tools/pull/151#discussion_r997488021


##########
maven-plugin-plugin/src/site/apt/examples/using-annotations.apt.vm:
##########
@@ -41,18 +41,22 @@ Using Plugin Tools Java Annotations
 
   Information for plugin descriptor generation is specified using 4 
annotations:
 
-  * 2 class-level annotations:
+  * 2 class level annotations:
 
     * <<<@Mojo>>>: This annotation will mark your class as a Mojo,
 
     * <<<@Execute>>>: Used if your Mojo needs to fork a lifecycle,
 
     []
 
-  * 2 field-level annotations:
+  * 1 filed or method level annotations:

Review Comment:
   How was this and my other remarks solved? I don't see a new commit...





> Allow @Parameter on setters methods
> -----------------------------------
>
>                 Key: MPLUGIN-419
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-419
>             Project: Maven Plugin Tools
>          Issue Type: New Feature
>            Reporter: Slawomir Jaranowski
>            Assignee: Slawomir Jaranowski
>            Priority: Major
>
> We needn't filed for Mojo parameters.
> When setters method exist it is called first by Maven.
> We can declare Mojo as:
> {code:java}
> @Mojo( name = "my-mojo" )
> public class MyMojo extends AbstractMojo
> {
>     @Parameter
>     private String param;
>     public void execute()
>     {
>     }
> }
> {code}
> In some case will be useful to have possibility to declare as:
> {code:java}
> @Mojo( name = "my-mojo" )
> public class MyMojo extends AbstractMojo
> {
>     @Parameter
>     public void setParam(String param)
>     {
>         // do something with param
>     }
>     public void execute()
>     {
>     }
> }
> {code}
> eg, useful:
> - normalization 
> - validation
> - split one input value to more items, the same or other type



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to