[
https://issues.apache.org/jira/browse/MNG-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614421#comment-17614421
]
ASF GitHub Bot commented on MNG-7547:
-------------------------------------
michael-o commented on code in PR #806:
URL: https://github.com/apache/maven/pull/806#discussion_r990610911
##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/PluginsMetadataGenerator.java:
##########
@@ -124,7 +126,50 @@ public Collection<? extends Metadata> finish( Collection<?
extends Artifact> art
}
}
}
-
return plugins.values();
}
+
+ private PluginInfo extractPluginInfo( Artifact artifact )
+ {
+ // sanity: jar, no classifier and file exists
+ if ( artifact != null
+ && "jar".equals( artifact.getExtension() )
+ && "".equals( artifact.getClassifier() )
+ && artifact.getFile() != null )
+ {
+ Path artifactPath = artifact.getFile().toPath();
+ if ( Files.isRegularFile( artifactPath ) )
Review Comment:
Thanks, that is what I wanted to hear. We won't get so far w/o building the
JAR.
> Simplify G level metadata handling
> ----------------------------------
>
> Key: MNG-7547
> URL: https://issues.apache.org/jira/browse/MNG-7547
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories, Plugins and Lifecycle
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> The original fix from MNG-7055 can be tremendously simplified: the plugins
> about to be deployed are JARs with embedded plugin descriptor, that contains
> all the required information (GA, prefix, name) to make G level metadata
> generator does everything on it's own, no need for hoops and loops at all.
> Actually, with this, all 3 generators becomes self-sufficient, and no need
> for caller to even fiddle with deploying metadata (as it happens
> automatically, courtesy of resolver and resolver-provider in maven).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
