[
https://issues.apache.org/jira/browse/MNG-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614419#comment-17614419
]
ASF GitHub Bot commented on MNG-7547:
-------------------------------------
michael-o commented on code in PR #806:
URL: https://github.com/apache/maven/pull/806#discussion_r990610832
##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/PluginsMetadataGenerator.java:
##########
@@ -35,42 +43,35 @@
import org.eclipse.aether.metadata.Metadata;
import org.eclipse.aether.util.ConfigUtils;
-import static java.util.Objects.requireNonNull;
-
/**
- * Plugin G level metadata.
+ * Maven G level metadata generator.
+ * <p>
+ * Plugin metadata contains G level list of "prefix" to A mapping for plugins
present under this G.
*/
class PluginsMetadataGenerator
- implements MetadataGenerator
+ implements MetadataGenerator
{
- private final PluginsMetadataInfoProvider pluginsMetadataInfoProvider;
-
- private final Map<Object, PluginsMetadata> plugins;
+ private static final String PLUGIN_DESCRIPTOR_LOCATION =
"META-INF/maven/plugin.xml";
Review Comment:
All good, it is consistent with the rest of our code.
> Simplify G level metadata handling
> ----------------------------------
>
> Key: MNG-7547
> URL: https://issues.apache.org/jira/browse/MNG-7547
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories, Plugins and Lifecycle
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> The original fix from MNG-7055 can be tremendously simplified: the plugins
> about to be deployed are JARs with embedded plugin descriptor, that contains
> all the required information (GA, prefix, name) to make G level metadata
> generator does everything on it's own, no need for hoops and loops at all.
> Actually, with this, all 3 generators becomes self-sufficient, and no need
> for caller to even fiddle with deploying metadata (as it happens
> automatically, courtesy of resolver and resolver-provider in maven).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
