[ 
https://issues.apache.org/jira/browse/MRESOLVER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609114#comment-17609114
 ] 

ASF GitHub Bot commented on MRESOLVER-273:
------------------------------------------

cstamas commented on code in PR #194:
URL: https://github.com/apache/maven-resolver/pull/194#discussion_r979380105


##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/named/HashingNameMapper.java:
##########
@@ -0,0 +1,85 @@
+package org.eclipse.aether.internal.impl.synccontext.named;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.util.Collection;
+import java.util.stream.Collectors;
+
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.metadata.Metadata;
+import org.eclipse.aether.util.ConfigUtils;
+import org.eclipse.aether.util.StringDigestUtil;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Wrapping {@link NameMapper}, that wraps another {@link NameMapper} and 
hashes resulting strings. It makes use of
+ * fact that (proper) Hash will create unique fixed length string for each 
different input string (so injection still
+ * stands). This mapper produces file system friendly names. Supports 
different "depths" (0-4 inclusive) where the
+ * name will contain 0 to 4 level deep directories.
+ * <p>
+ * This mapper is usable in any scenario, but intent was to produce more 
"compact" name mapper for file locking.
+ *
+ * @since TBD
+ */
+public class HashingNameMapper implements FileSystemFriendlyNameMapper
+{
+    private static final String CONFIG_PROP_DEPTH = 
"aether.syncContext.named.hashing.depth";
+
+    private final NameMapper delegate;
+
+    public HashingNameMapper( final NameMapper delegate )
+    {
+        this.delegate = requireNonNull( delegate );
+    }
+
+    @Override
+    public Collection<String> nameLocks( RepositorySystemSession session,
+                                         Collection<? extends Artifact> 
artifacts,
+                                         Collection<? extends Metadata> 
metadatas )
+    {
+        final int depth = ConfigUtils.getInteger( session, 2, 
CONFIG_PROP_DEPTH );
+        if ( depth < 0 || depth > 4 )
+        {
+            throw new IllegalArgumentException( "allowed depth 0 and 4 
(inclusive)" );
+        }
+        return delegate.nameLocks( session, artifacts, metadatas ).stream()
+                .map( n -> hashName( n, depth ) )
+                .collect( Collectors.toList() );
+    }
+
+    private String hashName( final String name, final int depth )
+    {
+        String hashedName = StringDigestUtil.sha1( name );
+        if ( depth == 0 )
+        {
+            return hashedName;
+        }
+        String prefix = "";
+        int i = 0;
+        while ( i < hashedName.length() && i / 2 < depth )
+        {
+            prefix += hashedName.substring( i, i + 2 ) + "/";
+            i += 2;
+        }
+        return prefix + hashedName;
+    }
+}

Review Comment:
   correct





> Create more compact File locking layout/mapper
> ----------------------------------------------
>
>                 Key: MRESOLVER-273
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-273
>             Project: Maven Resolver
>          Issue Type: Improvement
>          Components: Resolver
>            Reporter: Tamás Cservenák
>            Assignee: Tamás Cservenák
>            Priority: Major
>             Fix For: resolver-next
>
>
> Current FileGAVNameMapper "mimics" loosely local reposiory layout, uses long 
> paths, hence (relatively) big strings etc. 
> More compact layout would be just to hash strings like "a:G:A:V" and 
> "m:G[:A[:V]]" for artifacts and metadata instead, and create 2 level deep 
> hashed storage.
> Problem with "loose" layout is that they do end up as files in OS, while 
> these would be much shorter.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to